xfs
[Top] [All Lists]

Re: [PATCH 2/4] fsfreeze: manage kill signal when sb_start_write is call

To: Matthew Wilcox <matthew@xxxxxx>
Subject: Re: [PATCH 2/4] fsfreeze: manage kill signal when sb_start_write is called
From: Marco Stornelli <marco.stornelli@xxxxxxxxx>
Date: Sat, 06 Apr 2013 16:56:25 +0200
Cc: Linux FS Devel <linux-fsdevel@xxxxxxxxxxxxxxx>, Chris Mason <chris.mason@xxxxxxxxxxxx>, Steve French <sfrench@xxxxxxxxx>, Theodore Ts'o <tytso@xxxxxxx>, Andreas Dilger <adilger.kernel@xxxxxxxxx>, Miklos Szeredi <miklos@xxxxxxxxxx>, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, Anton Altaparmakov <anton@xxxxxxxxxx>, Mark Fasheh <mfasheh@xxxxxxxx>, Joel Becker <jlbec@xxxxxxxxxxxx>, Ben Myers <bpm@xxxxxxx>, Alex Elder <elder@xxxxxxxxxx>, xfs@xxxxxxxxxxx, Mike Snitzer <snitzer@xxxxxxxxxx>, Alasdair G Kergon <agk@xxxxxxxxxx>, linux-btrfs@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-cifs@xxxxxxxxxxxxxxx, samba-technical@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, fuse-devel@xxxxxxxxxxxxxxxxxxxxx, linux-ntfs-dev@xxxxxxxxxxxxxxxxxxxxx, ocfs2-devel@xxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, Jan Kara <jack@xxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=QFdgrfG/68tPuwSR4c3CUK5cEbug4Edyil57vi/7fdM=; b=jf7Olslb+1ODQlc0AJkmICQFBr9ub4k3ISCBlbGt0LEjYGuttYpnivDZXXaprz8yZf UHflFABtZZiOB+IjLVqGW7JgOWR+iqffuNdzfhaaV095lYFDKBtK3Sid2+GD/cxRapsV 1kmwxFQjNs5+knIvVpHQ4YdUVj4cHnWBEnQKLSNDPhr/yRMEsOSO7RIUoRFcXsTlNb5u YOXGggK52qmSCLLCa1fwC1rB4Ee8CLSiRIyrnbOi8JD2Tm0QY4+ZLIiiDSe+goqRz3Vl rLQC5uCfOVgihz1VPWBDnF+RPbTlnKc+yaQARv084voxmcj3l4PUm9G3IF3a6AgPvNVp ckLw==
In-reply-to: <20130406131703.GC28744@xxxxxxxxxxxxxxxx>
References: <515FF344.8040705@xxxxxxxxx> <20130406131703.GC28744@xxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130329 Thunderbird/17.0.5
Il 06/04/2013 15:17, Matthew Wilcox ha scritto:
On Sat, Apr 06, 2013 at 12:04:52PM +0200, Marco Stornelli wrote:
In every place where sb_start_write was called now we must manage
the error code and return -EINTR.

If we must manage the error code, then these functions should be marked
__must_check.


Yep, good point.

Marco

<Prev in Thread] Current Thread [Next in Thread>