xfs
[Top] [All Lists]

Re: [PATCH 2/4] fsfreeze: manage kill signal when sb_start_write is call

To: Marco Stornelli <marco.stornelli@xxxxxxxxx>
Subject: Re: [PATCH 2/4] fsfreeze: manage kill signal when sb_start_write is called
From: Matthew Wilcox <matthew@xxxxxx>
Date: Sat, 6 Apr 2013 07:17:03 -0600
Cc: Linux FS Devel <linux-fsdevel@xxxxxxxxxxxxxxx>, Chris Mason <chris.mason@xxxxxxxxxxxx>, Steve French <sfrench@xxxxxxxxx>, Theodore Ts'o <tytso@xxxxxxx>, Andreas Dilger <adilger.kernel@xxxxxxxxx>, Miklos Szeredi <miklos@xxxxxxxxxx>, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, Anton Altaparmakov <anton@xxxxxxxxxx>, Mark Fasheh <mfasheh@xxxxxxxx>, Joel Becker <jlbec@xxxxxxxxxxxx>, Ben Myers <bpm@xxxxxxx>, Alex Elder <elder@xxxxxxxxxx>, xfs@xxxxxxxxxxx, Mike Snitzer <snitzer@xxxxxxxxxx>, Alasdair G Kergon <agk@xxxxxxxxxx>, linux-btrfs@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-cifs@xxxxxxxxxxxxxxx, samba-technical@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, fuse-devel@xxxxxxxxxxxxxxxxxxxxx, linux-ntfs-dev@xxxxxxxxxxxxxxxxxxxxx, ocfs2-devel@xxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, Jan Kara <jack@xxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <515FF344.8040705@xxxxxxxxx>
References: <515FF344.8040705@xxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Sat, Apr 06, 2013 at 12:04:52PM +0200, Marco Stornelli wrote:
> In every place where sb_start_write was called now we must manage
> the error code and return -EINTR.

If we must manage the error code, then these functions should be marked
__must_check.

-- 
Matthew Wilcox                          Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."

<Prev in Thread] Current Thread [Next in Thread>