xfs
[Top] [All Lists]

Re: [PATCH] xfstests: Check concurrently of readdir and read on the same

To: Zhao Hongjiang <zhaohongjiang37@xxxxxxxxx>
Subject: Re: [PATCH] xfstests: Check concurrently of readdir and read on the same directory fd
From: Rich Johnston <rjohnston@xxxxxxx>
Date: Fri, 5 Apr 2013 12:28:29 -0500
Cc: <david@xxxxxxxxxxxxx>, <linux-fsdevel@xxxxxxxxxxxxxxx>, <linux-ext4@xxxxxxxxxxxxxxx>, <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <515BC786.3070102@xxxxxxxxx>
References: <515BC786.3070102@xxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20120615 Thunderbird/13.0.1
Zhao,

Thanks for submitting this test.

Only two minor errors that will be corrected at commit time.

1. The new script used generate this test produces errors.
  No need to resubmit, this has already been fixed by
  commit 8575764a "xfstests: fix common source file path"

     QA output created by 310
    +./tests/generic/310: line 43: ./common.rc: No such file or directory
+./tests/generic/310: line 44: ./common.filter: No such file or directory
    +./tests/generic/310: line 47: _supported_fs: command not found
    +./tests/generic/310: line 48: _supported_os: command not found

2. Whitespace errors
  Warning: trailing whitespace in line 18 of src/t_readdir_2.c
  Warning: trailing whitespace in lines 18,28 of src/t_readdir_1.c

  space before tab in indent. tests/generic/310
                                        perror("Seek failed!");
warning: 1 line adds whitespace errors.

Reviewed-by: Rich Johnston <rjohnston@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>