xfs
[Top] [All Lists]

Re: [PATCH] xfstests: fix common rc file path in new

To: Eryu Guan <eguan@xxxxxxxxxx>
Subject: Re: [PATCH] xfstests: fix common rc file path in new
From: Rich Johnston <rjohnston@xxxxxxx>
Date: Thu, 28 Mar 2013 22:18:01 -0500
Cc: <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <51546B33.6090608@xxxxxxx>
References: <1364478683-6752-1-git-send-email-eguan@xxxxxxxxxx> <51546B33.6090608@xxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120714 Thunderbird/14.0
On 03/28/2013 11:09 AM, Rich Johnston wrote:


You caught the first one but I think you should also change the template
entries too:

123 # get standard environment, filters and checks
124 . ./common/rc
125 . ./common/filter

Other than that looks good.

--Rich



I also noticed that there are several echo statements in the common directory that should be cleaned up with:

cd xfstests/common/
for f in `ls`; do sed -i -e's/common\./common\//g' $f; done

<Prev in Thread] Current Thread [Next in Thread>