Re: [PATCH] xfstests: remove unconditional setting of FSTYP

[David Sterba <dsterba@xxxxxxx>]

On Thu, Mar 28, 2013 at 04:39:07PM +0100, David Sterba wrote:
> Commit 3345d2150e9e672 ("xfstests: clean up and simply check CLI option
> parsing") hardcodes the FSTYP to xfs, testing other filesystems fails
> with
> 
> common.rc: Error: $TEST_DEV (/dev/sda5) is not a MOUNTED xfs filesystem
> 
> Signed-off-by: David Sterba <dsterba@xxxxxxx>

That's not a complete fix, I haven't noticed the automatic fs detection via
blkid, however it does not work because HOSTOS is not set:

./check:
 53 # Autodetect fs type based on what's on $TEST_DEV
 54 if [ "$HOSTOS" == "Linux" ]; then
 55     FSTYP=`blkid -c /dev/null -s TYPE -o value $TEST_DEV`
 56 fi

standalone "blkid -c /dev/null -s TYPE -o value $TEST_DEV`" works.

common/config:
 60 HOSTOS=`uname -s`

although 'uname -s' gives me Linux.


It works together with an explicit

export FSTYP=whatever


david