xfs
[Top] [All Lists]

Re: [PATCH] xfstests: fix common rc file path in new

To: Eryu Guan <eguan@xxxxxxxxxx>
Subject: Re: [PATCH] xfstests: fix common rc file path in new
From: Rich Johnston <rjohnston@xxxxxxx>
Date: Thu, 28 Mar 2013 11:09:23 -0500
Cc: <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1364478683-6752-1-git-send-email-eguan@xxxxxxxxxx>
References: <1364478683-6752-1-git-send-email-eguan@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20120615 Thunderbird/13.0.1
On 03/28/2013 08:51 AM, Eryu Guan wrote:
After the re-factor common.rc has been renamed to common/rc, fix the
path in script new, otherwise ./new reports

./new: line 26: ./common.rc: No such file or directory
Building include
Building lib
Building ltp
Building src
Building m4
./new: line 70: BEGIN{printf "%03d\n",+1}: command not found
Next test is
Error: test  already exists!

Signed-off-by: Eryu Guan <eguan@xxxxxxxxxx>
---
After applying this patch, ./new generates new test starting from 001,
so we have to maintain the seq number manually? Do we need an updated
version of new? eg. takes an argument to specify the test type like

        ./new generic
That's a good idea, and numbers based on the next number for that test type.

and generates new test based on existing seq number in generic dir.

  new | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/new b/new
index 94638f6..b21e75b 100755
--- a/new
+++ b/new
@@ -23,7 +23,7 @@

  # generic initialization
  iam=new
-. ./common.rc
+. ./common/rc

  trap "rm -f /tmp/$$.; exit" 0 1 2 3 15



You caught the first one but I think you should also change the template entries too:

123 # get standard environment, filters and checks
124 . ./common/rc
125 . ./common/filter

Other than that looks good.

--Rich


<Prev in Thread] Current Thread [Next in Thread>