[Top] [All Lists]

Re: Announce re-factor all current xfstests patches request

To: Theodore Ts'o <tytso@xxxxxxx>
Subject: Re: Announce re-factor all current xfstests patches request
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 28 Mar 2013 08:02:36 +1100
Cc: Rich Johnston <rjohnston@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>, linux-ext4@xxxxxxxxxxxxxxx, linux-btrfs <linux-btrfs@xxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130327190512.GA22889@xxxxxxxxx>
References: <5152F2BB.4000709@xxxxxxx> <20130327134606.GJ5861@xxxxxxxxx> <5153217B.5070909@xxxxxxx> <20130327190512.GA22889@xxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Mar 27, 2013 at 03:05:12PM -0400, Theodore Ts'o wrote:
> What do you think about renaming the existing tests from NNN to
> NNN-descriptive-name?  That way it will be easier for people who are
> trying to track regressions, since they can easily map from the new
> more descriptive name to the old test number for comparison purposes
> (i.e., to see whether a failure is a regression or not, etc.)

When named test support is done, then we could do this.

> Would you be open to changes which did this?  I'd suggest sending the
> changes as a shell script to minimize the chances of patch conflicts.
> It will cause people to need to regenerate their patches, but that
> means now would be the time to do this, when everyone will need to be
> fixing up their outstanding changes anyway.  :-)

There's more than just the rename of the file. group files have to
change, there's the possibility that the group list and test list
handling will need to be completely rewritten, the way test names
are output will need work, the result summaries will need to be
reformatted to be legible, etc.

So it's not just a case of renaming a file - there's still quite a
lot of infrastructure work needed before we can start using names
rather then sequence numbers for tests.


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>