xfs
[Top] [All Lists]

[PATCH v2 1/2] xfstests 308: check ctime updates for setfacl

To: xfs@xxxxxxxxxxx
Subject: [PATCH v2 1/2] xfstests 308: check ctime updates for setfacl
From: Eryu Guan <eguan@xxxxxxxxxx>
Date: Tue, 26 Mar 2013 20:52:21 +0800
Cc: Eryu Guan <eguan@xxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Check if ctime is updated and written to disk after setfacl

Regression test for the following extN commits
c6ac12a ext4: update ctime when changing the file's permission by setfacl
30e2bab ext3: update ctime when changing the file's permission by setfacl
523825b ext2: update ctime when changing the file's permission by setfacl

Signed-off-by: Eryu Guan <eguan@xxxxxxxxxx>
---
v2:
  1. echo "Silence is golden" to output file as suggested by Dave Chinner
  2. rebase on top of master

 308     | 80 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 308.out |  2 ++
 group   |  1 +
 3 files changed, 83 insertions(+)
 create mode 100644 308
 create mode 100644 308.out

diff --git a/308 b/308
new file mode 100644
index 0000000..9a77ca2
--- /dev/null
+++ b/308
@@ -0,0 +1,80 @@
+#! /bin/bash
+# FS QA Test No. 308
+#
+# Check if ctime is updated and written to disk after setfacl
+#
+# Regression test for the following extN commits
+# c6ac12a ext4: update ctime when changing the file's permission by setfacl
+# 30e2bab ext3: update ctime when changing the file's permission by setfacl
+# 523825b ext2: update ctime when changing the file's permission by setfacl
+#
+# Based on test 277
+#
+#-----------------------------------------------------------------------
+# Copyright (c) 2013 Red Hat, Inc.  All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+#-----------------------------------------------------------------------
+#
+# creator
+owner=eguan@xxxxxxxxxx
+
+seq=`basename $0`
+echo "QA output created by $seq"
+
+status=1       # failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+       cd /
+       rm -f $testfile
+}
+
+# get standard environment, filters and checks
+. ./common.rc
+. ./common.filter
+
+testfile=$SCRATCH_MNT/testfile.$seq
+
+# real QA test starts here
+_supported_fs generic
+_supported_os Linux
+_require_scratch
+
+echo "Silence is golden"
+
+_scratch_mkfs >/dev/null 2>&1
+_scratch_mount >/dev/null 2>&1
+
+touch $testfile
+_scratch_remount
+ctime1=`stat -c %Z $testfile`
+
+sleep 1
+setfacl -m 'u::x,g::x,o::x' $testfile
+ctime2=`stat -c %Z $testfile`
+
+_scratch_remount
+ctime3=`stat -c %Z $testfile`
+
+if [ "$ctime1" == "$ctime2" ]; then
+       echo "error: ctime not updated after setfacl"
+elif [ "$ctime1" == "$ctime3" ]; then
+       echo "error: on disk ctime not updated"
+else
+       status=0
+fi
+
+exit
diff --git a/308.out b/308.out
new file mode 100644
index 0000000..a731eaa
--- /dev/null
+++ b/308.out
@@ -0,0 +1,2 @@
+QA output created by 308
+Silence is golden
diff --git a/group b/group
index 97dc8f0..88f6800 100644
--- a/group
+++ b/group
@@ -431,3 +431,4 @@ stress
 305 aio dangerous enospc rw stress
 306 auto quick rw
 307 auto quick
+308 auto quick
-- 
1.8.1.4

<Prev in Thread] Current Thread [Next in Thread>