xfs
[Top] [All Lists]

Re: [PATCH] xfstests 276: use _require_no_large_scratch_dev instead of t

To: Wang Sheng-Hui <shhuiw@xxxxxxxxx>
Subject: Re: [PATCH] xfstests 276: use _require_no_large_scratch_dev instead of the removed _require_nobigloopfs
From: Rich Johnston <rjohnston@xxxxxxx>
Date: Mon, 25 Mar 2013 08:43:24 -0500
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, xfstests <xfs@xxxxxxxxxxx>, <linux-btrfs@xxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <514AA503.4060101@xxxxxxxxx>
References: <514AA503.4060101@xxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20120615 Thunderbird/13.0.1
On 03/21/2013 01:13 AM, Wang Sheng-Hui wrote:
_require_nobigloopfs has been removed.
We should use _require_no_large_scratch_dev in the test script.

Signed-off-by: Wang Sheng-Hui <shhuiw@xxxxxxxxx>
---
  276 |    3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/276 b/276
index 40b30cf..87363ca 100755
--- a/276
+++ b/276
@@ -58,8 +58,7 @@ _need_to_be_root
  _supported_fs btrfs
  _supported_os Linux
  _require_scratch
-
-_require_nobigloopfs
+_require_no_large_scratch_dev
  _require_btrfs inspect-internal
  _require_command "/usr/sbin/filefrag"


Thanks for the patch.

Not sure what is wrong with your patch (trailing space maybe),
but it could not be imported using git quiltimport.

The patch itself makes sense so I have committed the attached:

Reviewed-by: Rich Johnston <rjohnston@xxxxxxx>

commit 07c1f8d7bae36f2c28ffee6f09c318b1142b6f90
Author: Wang Sheng-Hui <shhuiw@xxxxxxxxx>
Date:   Thu Mar 21 06:13:23 2013 +0000

xfstests 276: use _require_no_large_scratch_dev instead of the removed _require_nobigloopfs

Attachment: p276.patch
Description: Text Data

<Prev in Thread] Current Thread [Next in Thread>