[Top] [All Lists]

Re: [PATCH] xfstests 276: use _require_no_large_scratch_dev instead of t

To: Dave Chinner <dchinner@xxxxxxxxxx>, xfstests <xfs@xxxxxxxxxxx>, linux-btrfs@xxxxxxxxxxxxxxx
Subject: Re: [PATCH] xfstests 276: use _require_no_large_scratch_dev instead of the removed _require_nobigloopfs
From: Wang Sheng-Hui <shhuiw@xxxxxxxxx>
Date: Mon, 25 Mar 2013 12:35:06 +0800
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=zqSEoadg6dMomtsLWymDsbTcnG8GBUymgjfQidgQyjM=; b=Ge5+4O5UgJKIrXBL/7jyA6aFZd9fqUWMQO8XDvC1pHNHwljCZo4t8+cmus4jJa3kep DUsK0Ec/V3rTF5H0iP7+mYRlu+c22ByVNRLSS8DUimVnpRzfPRv5pDt86CXCNtyqxThc eduwyebvr/yBpPbFDcMxF6aYgvoawLkBqVvWGl4rrdVU7NXAzf6MMVAkRNiy4f3hp7Gn dTYZgAYBP/bCP/WNskT0CMFKhla593+E7W2KOqA5aE9HpJOePnv2kg/qB6UYyaCCdVt6 vrQGnwGjr4mHzS7HqJURfsOcgTJac0UNvO2jvJYnxQi7xICQZ0XVa3bfG9jbxslhaIk3 xzzQ==
In-reply-to: <514AA503.4060101@xxxxxxxxx>
References: <514AA503.4060101@xxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0
On 2013å03æ21æ 14:13, Wang Sheng-Hui wrote:
_require_nobigloopfs has been removed.
We should use _require_no_large_scratch_dev in the test script.

Signed-off-by: Wang Sheng-Hui <shhuiw@xxxxxxxxx>
  276 |    3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/276 b/276
index 40b30cf..87363ca 100755
--- a/276
+++ b/276
@@ -58,8 +58,7 @@ _need_to_be_root
  _supported_fs btrfs
  _supported_os Linux
  _require_btrfs inspect-internal
  _require_command "/usr/sbin/filefrag"

Does anyone notice this?
I use the upstream xfstests and failed this case for the already-removed 
I think someone patched in but mixed the old function.
I've send out this patch for days, but seems no one cares about it.

If I'm wrong, please let me know.


<Prev in Thread] Current Thread [Next in Thread>