xfs
[Top] [All Lists]

Re: [PATCH] xfstests: add execution of a custom command to fsstress (-x

To: Jan Schmidt <list.xfs@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: add execution of a custom command to fsstress (-x and -X options)
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 22 Mar 2013 06:50:54 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1363863585-25598-1-git-send-email-list.xfs@xxxxxxxxxxxxx>
References: <1363863585-25598-1-git-send-email-list.xfs@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Mar 21, 2013 at 11:59:45AM +0100, Jan Schmidt wrote:
> From: Jan Schmidt <list.btrfs@xxxxxxxxxxxxx>
> 
> This patch adds execution of a custom command in the middle of all fsstress
> operations. Its intended use is the creation of snapshots in the middle of a
> test run.

Why do you need fsstress to do this? Why can't you just run fsstress
in the background and run a loop creating periodic snapshots in the
control script?

Also, did you intend that every process creates a snapshot? i.e. it
looks lik eif you run a 1000 processes, they'll all run a snapshot
operation at X operations? i.e. this will generate nproc * X
snapshots in a single run. This doesn't seem very wise to me....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>