xfs
[Top] [All Lists]

Re: [PATCH] xfstests 299-305: remove fio config files after finished tes

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfstests 299-305: remove fio config files after finished test
From: Zheng Liu <gnehzuil.liu@xxxxxxxxx>
Date: Wed, 20 Mar 2013 13:37:44 +0800
Cc: xfs@xxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, Zheng Liu <wenqing.lz@xxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=nMQqyG+/quw0W+hzL9yy7lnkhaYZA6CWNxPHYGGqyVk=; b=nZefWQZZEjpvOZVxdj6vimapKnoXD4UhqaKe6fxFkrjvR2bVLvA8KBcNHFypG2bxH7 bmbBKkvVgyas68aJo7igMK4MHFEq+yEyGQvKHIdeX7Jcldbk6D/gVybNAjC+SbcZTqzb 6UKsZMZBReRRFqCn9tV4LJgBLQiAxa6RAcdbMibhfgqO/pDk0jRUvfb8kSULwDranVUI XJNgYpxQBCFdAFe1MyclSiYusOO6l7quW4pU1eYqcrXFQO6jDRtvdNAu1JhrSYIWhyIs 3Z3R3BII3RDTV4TyZ+WaBB6QLgOyp0RqUg0FO0gkEpfD3odqGIKUDQa2SUTU7NODZvuy MgWg==
In-reply-to: <51489024.20301@xxxxxxxxxxx>
Mail-followup-to: Eric Sandeen <sandeen@xxxxxxxxxxx>, xfs@xxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, Zheng Liu <wenqing.lz@xxxxxxxxxx>
References: <1363685450-27452-1-git-send-email-wenqing.lz@xxxxxxxxxx> <51489024.20301@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Mar 19, 2013 at 11:19:48AM -0500, Eric Sandeen wrote:
> On 3/19/13 4:30 AM, Zheng Liu wrote:
> > From: Zheng Liu <wenqing.lz@xxxxxxxxxx>
> > 
> > After finished test, temporarily fio config file should be removed.
> 
> Looks fine, except that in test 300 you don't do rm -f; in every
> other test -f is used.  Was that intentional?

Thanks for pointing it out.  It's a typo.  I will submit a newer patch
to fix it.

> 
> Also, while looking at this, in 305 cleanup uses "poweron_scratch_dev"
> - is that defined anywhere?  I can't find it.

Yeah, I also cannot find it.  I am not sure why it is called here.  I
will take a look at it and make sure that we can remove it.

Regards,
                                                - Zheng

<Prev in Thread] Current Thread [Next in Thread>