xfs
[Top] [All Lists]

Re: [PATCH 01/13] xfstests: filter new repair/mkfs output for CRCs

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [PATCH 01/13] xfstests: filter new repair/mkfs output for CRCs
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 20 Mar 2013 09:52:30 +1100
Cc: Rich Johnston <rjohnston@xxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130319205801.GG22182@xxxxxxx>
References: <1363348411-21867-1-git-send-email-david@xxxxxxxxxxxxx> <1363348411-21867-2-git-send-email-david@xxxxxxxxxxxxx> <20130319205801.GG22182@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Mar 19, 2013 at 03:58:01PM -0500, Ben Myers wrote:
> Hey Rich,
>    
> On Fri, Mar 15, 2013 at 10:53:19PM +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > This patch it to ensure that xfstests passes on non-crc filesystems
> > with a CRC enabled userspace.
> > 
> > Filter out the mkfs/xfs_info CRC line from tests that capture the
> > output of these commands.
> > 
> > Filter out new error noise from xfs_repair that occurs for
> > xfs_repair as a result of the CRC changes.
> 
> IIRC this change was a temporary one so that xfstests could be run with crc
> enabled filesystems.

It's going to be a permanent change because we dump mkfs.xfs output
into golden output files and that means the "crc=X" line will always
need to be filtered out

> > diff --git a/common.repair b/common.repair
> > index 23a1ed6..db160bb 100644
> > --- a/common.repair
> > +++ b/common.repair
> > @@ -77,6 +77,9 @@ s/\s+- \d+:\d\d:\d\d:.*\n//g;
> >  /^agi_/ && next; # remove agi counts
> >  /^sb_/ && next; # remove sb counts
> >  /^agi unlinked/ && next; # remove agi unlinked bucket warning
> > +# crc enabled filesystem output
> > +/XFS_CORRUPTION_ERROR/ && next;
> > +/^bad uuid/ && next;
> 
> Doesn't this filter out xfs repair failures which should be reported?

No, because repair will issue errors when bad metadata is read off
disk now, and as such they are brand new output introduced by the
CRC patches. Over time this might get cleaned up, but at least for
initial testing and debugging this noise will remain in the repair
code....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>