xfs
[Top] [All Lists]

Re: [PATCH V2] xfstests: test writing to device node on an RO filesystem

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH V2] xfstests: test writing to device node on an RO filesystem
From: Rich Johnston <rjohnston@xxxxxxx>
Date: Fri, 15 Mar 2013 11:11:12 -0500
Cc: Eric Sandeen <sandeen@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <514345D5.8090005@xxxxxxxxxxx>
References: <514243C0.1000309@xxxxxxxxxx> <5142896E.9060609@xxxxxxxxxxx> <5143457A.6060303@xxxxxxx> <514345D5.8090005@xxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20120615 Thunderbird/13.0.1
On 03/15/2013 11:01 AM, Eric Sandeen wrote:
On 3/15/13 10:59 AM, Rich Johnston wrote:
Eric,

Thanks again for the new test. A few minor issues that can be corrected at 
commit time.

Reviewed-by: Rich Johnston <rjohnston@xxxxxxx>

I can correct this a commit time.

quilt refresh
Warning: trailing whitespace in line 24 of 306
Refreshed patch 
patches/V2-xfstests-test-writing-to-device-node-on-an-RO-filesystem.patch

Do you also want me to add this top the quick group as Dave suggested when I 
commit this?

Sure, thanks for that, and sorry my patches always seem so sloppy.  I mean 
well, and I try.  I'll try harder. ;)

Hehe no worries.


-Eric

Thanks
--Rich





This has been commited (with the correct test number this time ;) )

Thanks
--Rich

commit f835afd3f0f2bab78b5b303744bb9ad441276c02
Author: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date:   Fri Mar 15 02:37:34 2013 +0000

    xfstests: test writing to device node on an RO filesystem

    We should be able to open device nodes for writing even
    if they live on a readonly filesytem.

    Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
    Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
    Reviewed-by: Rich Johnston <rjohnston@xxxxxxx>
    Signed-off-by: Rich Johnston <rjohnston@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>