xfs
[Top] [All Lists]

Re: [PATCH 3/3 V4] xfstests: btrfs tests for basic informational command

To: Rich Johnston <rjohnston@xxxxxxx>
Subject: Re: [PATCH 3/3 V4] xfstests: btrfs tests for basic informational commands
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Fri, 15 Mar 2013 09:36:23 -0500
Cc: Eric Sandeen <esandeen@xxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxx>, "linux-btrfs@xxxxxxxxxxxxxxx" <linux-btrfs@xxxxxxxxxxxxxxx>, "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <51432EC5.5090208@xxxxxxx>
References: <1363186623-1378-1-git-send-email-sandeen@xxxxxxxxxx> <1363186623-1378-4-git-send-email-sandeen@xxxxxxxxxx> <5140AB9D.2070001@xxxxxxxxxx> <5140CB3F.5010704@xxxxxxxxxx> <5140CD26.7050201@xxxxxxxxxxx> <20130315101625.GE6369@dastard> <737235E6-72C8-45F5-A6F4-EEEFD094706E@xxxxxxxxxx> <51432EC5.5090208@xxxxxxx>
On Mar 15, 2013, at 9:23 AM, Rich Johnston <rjohnston@xxxxxxx> wrote:

> On 03/15/2013 08:46 AM, Eric Sandeen wrote:
>> Yep sorry.  I figure its always a race in numbers do I don't bother with 
>> fixing them up.  Should I?
> 
> Eric,
> I was going to revert and resubmit as test 306, is that OK with you?
> 
Sure, of course.

Thanks,
Eric

>> On Mar 15, 2013, at 5:16 AM, Dave Chinner <david@xxxxxxxxxxxxx> wrote:
>> 
>>> On Wed, Mar 13, 2013 at 02:01:58PM -0500, Eric Sandeen wrote:
>>>> Run basic btrfs information commands in various ways, performing
>>>> sanity tests of: filesystem show, label, sync, and device stats
>>>> (sync is included just because it's simple).  These are mostly
>>>> just smoke tests, although for example show by label & UUID
>>>> should verify that the correct fs was shown.
>>>> 
>>>> This also add2730c49a3s quite a few new filters to accommodate the output
>>>> of the new commands.
>>>> 
>>>> Cc: linux-btrfs@xxxxxxxxxxxxxxx
>>>> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
>>>> ---
>>>> 
>>>> V2: sort & uniq device stats output to account for variable
>>>> nrs. of devices.  Optionally check that the proper nr. of
>>>> devices was returned, as well.
>>>> 
>>>> V3: _filter_uuid needs to pay attention to $1, not hope
>>>> that the caller has set $UUID.  Oops.
>>>> 
>>>> V4: fix stats filter to set UNIQ_OPT in both cases, ugh.
>>> 
>>> Something I just noticed in this commit:
>>> 
>>>> +# get standard environment, filters and checks
>>>> +. ./common.rc
>>>> +. ./btrfs.filter
>>> 
>>> That should probably have been named "common.filter.btrfs".
> 
> Dave,
> Do you want me to rename btrfs.filter to common.filter.btrfs when I resubmit 
> this patch?
> 
> Regards
> --Rich
> 
>>> I found this updating my patchset that moves all the common.* files
>>> into a common/ directory....
>>> 
>>> I'll rename it to common/filter.btrfs....
>>> 
>>> Cheers,
>>> 
>>> Dave.
>>> --
>>> Dave Chinner
>>> david@xxxxxxxxxxxxx
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
>>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> 
>> _______________________________________________
>> xfs mailing list
>> xfs@xxxxxxxxxxx
>> http://oss.sgi.com/mailman/listinfo/xfs
> 
> 

<Prev in Thread] Current Thread [Next in Thread>