xfs
[Top] [All Lists]

Re: [PATCH 14/18] xfstests: remove -x functionality

To: Philip White <pwhite@xxxxxxx>
Subject: Re: [PATCH 14/18] xfstests: remove -x functionality
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Fri, 15 Mar 2013 09:13:46 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130314130611.A163253DEAFB@xxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <20130314130611.A163253DEAFB@xxxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130216 Thunderbird/17.0.3
On 3/14/13 8:06 AM, Philip White wrote:
> From: Phil White <pwhite@xxxxxxx>
> 
> 
> This is a rebasing & resubmit of a dchinner patch.  His comments on the
> original:
> -----------------
> Now that there are no tests in the top level directory, the exlude
> group functionality no longer works (-x group) as it cannot find
> tests to build an initial list of tests. Rework the the exclude
> group implementation to operate correctly on the new test locations.
> 
> Also, swtich from sed to grep for exclusion because sed has problems
> distnguishing the '/' in path names from regex control...
> -----------------
> This one is mildly different from the original as it modifies infrastructure
> which remains in common.  In Dave's original patch, that had all been moved
> into check.

And the rationale for the change from the original is what?  Changelogs are 
better with reasoning, than with just descriptions of change.

Just a style note - it's not great form to take someone else's large body of 
work, tweak it, then claim authorship (From:) and sign-off (Signed-off-by:).  
If it were me, I might be a little tweaked.  It's probably an oversight, and 
maybe Dave doesn't even care, but it's my pet peeve.

Since Dave has rebased & resent the original patchset he wrote, it might be 
better, going forward, for you guys to try to reach agreement on any necessary 
changes to his body of work, and get that committed.  Unless we want to carry 
on w/ dueling patchsets, which doesn't sound optimal to me.

-Eric

<Prev in Thread] Current Thread [Next in Thread>