[Top] [All Lists]

Re: [PATCH 3/3 V4] xfstests: btrfs tests for basic informational command

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH 3/3 V4] xfstests: btrfs tests for basic informational commands
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 15 Mar 2013 21:16:25 +1100
Cc: Eric Sandeen <sandeen@xxxxxxxxxx>, linux-btrfs@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <5140CD26.7050201@xxxxxxxxxxx>
References: <1363186623-1378-1-git-send-email-sandeen@xxxxxxxxxx> <1363186623-1378-4-git-send-email-sandeen@xxxxxxxxxx> <5140AB9D.2070001@xxxxxxxxxx> <5140CB3F.5010704@xxxxxxxxxx> <5140CD26.7050201@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Mar 13, 2013 at 02:01:58PM -0500, Eric Sandeen wrote:
> Run basic btrfs information commands in various ways, performing
> sanity tests of: filesystem show, label, sync, and device stats
> (sync is included just because it's simple).  These are mostly
> just smoke tests, although for example show by label & UUID
> should verify that the correct fs was shown.
> This also adds quite a few new filters to accommodate the output
> of the new commands.
> Cc: linux-btrfs@xxxxxxxxxxxxxxx
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---
> V2: sort & uniq device stats output to account for variable
> nrs. of devices.  Optionally check that the proper nr. of
> devices was returned, as well.
> V3: _filter_uuid needs to pay attention to $1, not hope
> that the caller has set $UUID.  Oops.
> V4: fix stats filter to set UNIQ_OPT in both cases, ugh.

Something I just noticed in this commit:

> +# get standard environment, filters and checks
> +. ./common.rc
> +. ./btrfs.filter

That should probably have been named "common.filter.btrfs".
I found this updating my patchset that moves all the common.* files
into a common/ directory....

I'll rename it to common/filter.btrfs....


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>