[Top] [All Lists]

Re: [PATCH 14/18] xfstests: remove -x functionality

To: Philip White <pwhite@xxxxxxx>
Subject: Re: [PATCH 14/18] xfstests: remove -x functionality
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 15 Mar 2013 19:47:32 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130314130611.A163253DEAFB@xxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <20130314130611.A163253DEAFB@xxxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Mar 14, 2013 at 06:06:11AM -0700, Philip White wrote:
> From: Phil White <pwhite@xxxxxxx>
> This is a rebasing & resubmit of a dchinner patch.  His comments on the
> original:
> -----------------
> Now that there are no tests in the top level directory, the exlude
> group functionality no longer works (-x group) as it cannot find
> tests to build an initial list of tests. Rework the the exclude
> group implementation to operate correctly on the new test locations.
> Also, swtich from sed to grep for exclusion because sed has problems
> distnguishing the '/' in path names from regex control...
> -----------------
> This one is mildly different from the original as it modifies infrastructure
> which remains in common.  In Dave's original patch, that had all been moved
> into check.

Why change the patch title? It still does what the original patch
did, so the new patch title is incorrect....


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>