On Thu, Mar 14, 2013 at 06:06:11AM -0700, Philip White wrote:
> From: Phil White <pwhite@xxxxxxx>
>
>
> This is a rebasing & resubmit of a dchinner patch. His comments on the
> original:
> -----------------
> And into tests/xfs. Tests found and moved via:
>
> $ grep "supported_fs xfs$" [0-2]* | cut -d : -f 1 > xfs.tests
> $ for i in `cat xfs.tests`; do
> > git mv $i* tests/xfs/
> > grep ^$i group >> tests/xfs/group
> > sed -i -e "/^$i/d" group
> > done
>
> Output now looks like:
>
> sudo ./check -g quick -r
> FSTYP -- xfs (debug)
> PLATFORM -- Linux/x86_64 test-1 3.5.0-rc5-dgc+
> MKFS_OPTIONS -- -f -bsize=4096 /dev/vdb
> MOUNT_OPTIONS -- /dev/vdb /mnt/scratch
>
> xfs/170 4s
> generic/120 16s
> generic/248 0s
> generic/213 0s
> generic/256 39s
> xfs/121 6s
> xfs/026 11s
> generic/131 1s
> xfs/187 1s
> generic/135 0s
> ....
> -----------------
> For ease of reviewing, I put all the actual test movements into a separate
> patch.
Where is that patch - I don't see it in the series.
As it is, moving the files in a different patch to the group file
changes breaks xfstests. One of the things I made sure of was that
after each patch, the entire set of tests still ran properly with
something like "./check -g auto", and this separation looks lik eit
breaks that.
As it is, nobody is going to review a patch that has a diffstat of
+/-80,000 lines, which means it's irrelevant if it is in another
patch or not. As such, you don't need to send such patches as traditional diffs
-
the git aware diff format is far better for this and easy to review
even whenteh file movement in is the same patch. See
http://oss.sgi.com/archives/xfs/2012-07/msg00389.html
To see how i sent this previously.
You are using git (though a very old version), so you should be bale
to get patches output in the correct manner...
-Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx
|