xfs
[Top] [All Lists]

Re: [PATCH] xfsdump: properly set Parent's PID

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfsdump: properly set Parent's PID
From: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
Date: Wed, 13 Mar 2013 09:58:56 -0300
Cc: Rich Johnston <rjohnston@xxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130313124651.GA2816@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <1359663197-30473-1-git-send-email-cmaiolino@xxxxxxxxxx> <513F58FE.1010200@xxxxxxx> <513FFC0D.3030705@xxxxxxxxxxx> <20130313124651.GA2816@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
Ah, my origin was pointing to the git.kernel.org xfsdump repository =[

On Wed, Mar 13, 2013 at 09:46:52AM -0300, Carlos Maiolino wrote:
> Weird, I git pull'ed the repository before add the patch, I'll review my
> origin's URL, sorry about that
> 
> On Tue, Mar 12, 2013 at 11:09:49PM -0500, Eric Sandeen wrote:
> > On 3/12/13 11:34 AM, Rich Johnston wrote:
> > > On 01/31/2013 02:13 PM, Carlos Maiolino wrote:
> > >> Set parentpid variable to the correct Parent's ID using getppid() 
> > >> instead of
> > >> getpid()
> > >>
> > >> Signed-off-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
> > >> ---
> > >>   common/main.c | 2 +-
> > >>   1 file changed, 1 insertion(+), 1 deletion(-)
> > >>
> > >> diff --git a/common/main.c b/common/main.c
> > >> index 980d2d4..848a887 100644
> > >> --- a/common/main.c
> > >> +++ b/common/main.c
> > >> @@ -198,7 +198,7 @@ main( int argc, char *argv[] )
> > >>       /* Get the parent's pid. will be used in signal handling
> > >>        * to differentiate parent from children.
> > >>        */
> > >> -    parentpid = getpid( );
> > >> +    parentpid = getppid( );
> > >>       rval = atexit(mlog_exit_flush);
> > >>       assert(rval == 0);
> > >>
> > >>
> > > Sorry for the late review, this does not apply to current xfsdump tree.
> > 
> > Hm, and hasn't since 2011.  ;)
> > 
> > 2da84e5d changed this:
> > 
> >          * to differentiate parent from children.
> >          */
> > -       parentpid = getpid( );
> > +       parenttid = pthread_self( );
> > 
> > Carlos, was this maybe against an older tree or released version?
> > 
> > -Eric
> > 
> > > Regards
> > > --Rich
> > 
> > _______________________________________________
> > xfs mailing list
> > xfs@xxxxxxxxxxx
> > http://oss.sgi.com/mailman/listinfo/xfs
> 
> -- 
> Carlos
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

-- 
Carlos

<Prev in Thread] Current Thread [Next in Thread>