xfs
[Top] [All Lists]

Re: [PATCH] xfsdump: properly set Parent's PID

To: Rich Johnston <rjohnston@xxxxxxx>
Subject: Re: [PATCH] xfsdump: properly set Parent's PID
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Tue, 12 Mar 2013 23:09:49 -0500
Cc: Carlos Maiolino <cmaiolino@xxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <513F58FE.1010200@xxxxxxx>
References: <1359663197-30473-1-git-send-email-cmaiolino@xxxxxxxxxx> <513F58FE.1010200@xxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130216 Thunderbird/17.0.3
On 3/12/13 11:34 AM, Rich Johnston wrote:
> On 01/31/2013 02:13 PM, Carlos Maiolino wrote:
>> Set parentpid variable to the correct Parent's ID using getppid() instead of
>> getpid()
>>
>> Signed-off-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
>> ---
>>   common/main.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/common/main.c b/common/main.c
>> index 980d2d4..848a887 100644
>> --- a/common/main.c
>> +++ b/common/main.c
>> @@ -198,7 +198,7 @@ main( int argc, char *argv[] )
>>       /* Get the parent's pid. will be used in signal handling
>>        * to differentiate parent from children.
>>        */
>> -    parentpid = getpid( );
>> +    parentpid = getppid( );
>>       rval = atexit(mlog_exit_flush);
>>       assert(rval == 0);
>>
>>
> Sorry for the late review, this does not apply to current xfsdump tree.

Hm, and hasn't since 2011.  ;)

2da84e5d changed this:

         * to differentiate parent from children.
         */
-       parentpid = getpid( );
+       parenttid = pthread_self( );

Carlos, was this maybe against an older tree or released version?

-Eric

> Regards
> --Rich

<Prev in Thread] Current Thread [Next in Thread>