[Top] [All Lists]

Re: [PATCH] xfs: Remove obsoleted m_inode_shrink from xfs_mount structur

To: Jeff Liu <jeff.liu@xxxxxxxxxx>
Subject: Re: [PATCH] xfs: Remove obsoleted m_inode_shrink from xfs_mount structure
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Mon, 11 Mar 2013 12:59:18 -0500
Cc: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>, dchinner@xxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <513D7A26.3030401@xxxxxxxxxx>
References: <513D7A26.3030401@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 03/11/13 01:31, Jeff Liu wrote:
Looks the old m_inode_shrink is obsoleted as we perform inodes reclaim per AG 
m_reclaim_workqueue, this patch remove it from the xfs_mount structure if so.

Signed-off-by: Jie Liu<jeff.liu@xxxxxxxxxx>
Cc: Dave Chinner<dchinner@xxxxxxxxxx>
  fs/xfs/xfs_mount.h |    1 -
  1 file changed, 1 deletion(-)

diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h
index bc90706..687c171 100644
--- a/fs/xfs/xfs_mount.h
+++ b/fs/xfs/xfs_mount.h
@@ -207,7 +207,6 @@ typedef struct xfs_mount {
                                                     trimming */
        __int64_t               m_update_flags; /* sb flags we need to update
                                                   on the next remount,rw */
-       struct shrinker         m_inode_shrink; /* inode reclaim shrinker */
        int64_t                 m_low_space[XFS_LOWSP_MAX];
                                                /* low free space thresholds */

Obsoleted in commit:

commit 8daaa83145ef1f0a146680618328dbbd0fa76939
Author: Dave Chinner <dchinner@xxxxxxxxxx>
Date:   Fri Jul 8 14:14:46 2011 +1000

    xfs: make use of new shrinker callout for the inode cache

Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>