xfs
[Top] [All Lists]

Re: [PATCH] xfs: ensure we capture IO errors correctly

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: ensure we capture IO errors correctly
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Mon, 11 Mar 2013 09:00:45 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1362708074-14987-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1362708074-14987-1-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 03/07/13 20:01, Dave Chinner wrote:
From: Dave Chinner<dchinner@xxxxxxxxxx>

Failed buffer readahead can leave the buffer in the cache marked
with an error. Most callers that then issue a subsequent read on the
buffer do not zero the b_error field out, and so we may incorectly
detect an error during IO completion due to the stale error value
left on the buffer.

Avoid this problem by zeroing the error before IO submission. This
ensures that the only IO errors that are detected those captured
from are those captured from bio submission or completion.

Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
---

Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>