xfs
[Top] [All Lists]

Re: [PATCH V2] xfs_repair: skip freelist scan of corrupt agf in no-modif

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH V2] xfs_repair: skip freelist scan of corrupt agf in no-modify mode
From: Rich Johnston <rjohnston@xxxxxxx>
Date: Mon, 11 Mar 2013 07:20:35 -0500
Cc: Eric Sandeen <sandeen@xxxxxxxxxxx>, Ole Tange <tange@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130309090041.GG23616@dastard>
References: <51313DE8.5080104@xxxxxxxxxxx> <51326DC0.8030403@xxxxxxxxxxx> <513A4A9B.3050802@xxxxxxx> <20130309090041.GG23616@dastard>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20120615 Thunderbird/13.0.1
On 03/09/2013 03:00 AM, Dave Chinner wrote:
On Fri, Mar 08, 2013 at 02:31:23PM -0600, Rich Johnston wrote:
This version looks good. ;)

Reviewed-by: Rich Johnston <rjohnston@xxxxxxx>

This has been committed.

Except that all review comments have not been addressed. i.e there
are two places that have the same bug and they haven't been fixed.

It's great that you want to commit quickly, but commits should not
happen while there are unaddressed issues still outstanding....

Sorry Dave I misunderstood your comments. I took them to mean you were going to make those changes with your CRC patch. I will make sure to clarify before committing.


Cheers,

Dave.



<Prev in Thread] Current Thread [Next in Thread>