xfs
[Top] [All Lists]

Re: xfstests: 301: sparse copy between different filesystems/mountpoints

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: xfstests: 301: sparse copy between different filesystems/mountpoints on btrfs
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Sun, 10 Mar 2013 20:40:31 -0500
Cc: Koen De Wit <koen.de.wit@xxxxxxxxxx>, linux-btrfs <linux-btrfs@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130310230325.GM23616@dastard>
References: <50F9C331.9000501@xxxxxxxxxx> <513BD2CF.5020204@xxxxxxxxxxx> <20130310230325.GM23616@dastard>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130216 Thunderbird/17.0.3
On 3/10/13 6:03 PM, Dave Chinner wrote:
> On Sat, Mar 09, 2013 at 06:24:47PM -0600, Eric Sandeen wrote:
>> On 1/18/13 3:48 PM, Koen De Wit wrote:
>>> +}
>>> +
>>> +_scratch_mount
>>> +_create_reflinks_to $TESTDIR2
>>> +_scratch_unmount
>>> +
>>> +mount $TEST_DEV $SCRATCH_MNT
>>> +_create_reflinks_to $TESTDIR3
>>> +umount $SCRATCH_MNT
>>
>> TBH this confuses me, not that it's necessarily wrong (?)
>> You mount TEST_DEV on $SCRATCH_MNT which makes my brain hurt a little.
>> Then _create_reflinks_to $TESTDIR3 and at that point, um, what's going on,
>> what's linking what to where?
> 
> Mounting the TEST_DEV on SCRATCH_MNT is almost always a bad thing to
> do. The test harness expects TEST_DEV to be mounted on TEST_DIR, not
> anywhere else.
> 
> If you need multiple scratch filesystems to test cross-device
> linkage errors, use loopback devices or make use of the btrfs
> scratch device pool...

Actually, looking at it again - does this wind up with TEST_DEV mounted
on both TEST_DIR and SCRATCH_MNT?  Maybe what the test wants is more
mountpoints, not more devices?

-Eric

> Cheers,
> 
> Dave.
> 

<Prev in Thread] Current Thread [Next in Thread>