xfs
[Top] [All Lists]

Re: [PATCH V2] xfs_repair: skip freelist scan of corrupt agf in no-modif

To: Rich Johnston <rjohnston@xxxxxxx>
Subject: Re: [PATCH V2] xfs_repair: skip freelist scan of corrupt agf in no-modify mode
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Sat, 09 Mar 2013 09:00:55 -0600
Cc: Ole Tange <tange@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <513A4A9B.3050802@xxxxxxx>
References: <51313DE8.5080104@xxxxxxxxxxx> <51326DC0.8030403@xxxxxxxxxxx> <513A4A9B.3050802@xxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130216 Thunderbird/17.0.3
On 3/8/13 2:31 PM, Rich Johnston wrote:
> This version looks good. ;)

Actually it's not quite:

scan.c: In function ‘scan_freelist’:
scan.c:1074: warning: ‘i’ may be used uninitialized in this function

I don't know what's wrong with my brain these days.  :/

I will send a patch to fix that along w/ the other scan_freelists shortly.

Sorry :/

-Eric

> Reviewed-by: Rich Johnston <rjohnston@xxxxxxx>
> 
> This has been committed.
> 
> commit 7e8e3cce00f38ee1533df0e7bda6bcb584b03e96
> Author: Eric Sandeen <sandeen@xxxxxxxxxxx>
> Date:   Sat Mar 2 21:23:12 2013 +0000
> 
>     xfsprogs: xfs_repair skip freelist scan of corrupt agf in no-modify mode
> 
>     In xfs_repair's no-modify mode (-n), verify_set_agf doesn't fix up
>     bad freelist blocks that it finds.  When we get to scan_freelist,
>     this can wreak havoc if, for example, first > last and the loop
>     never exits; we index agfl->agfl_bno[i] off into the weeds.
> 
>     To fix this, re-check the values in no-modify mode, and if
>     they're off, warn about it and skip the scan.
> 
> 
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
> 

<Prev in Thread] Current Thread [Next in Thread>