xfs
[Top] [All Lists]

Re: [PATCH V2] xfs_repair: skip freelist scan of corrupt agf in no-modif

To: Rich Johnston <rjohnston@xxxxxxx>
Subject: Re: [PATCH V2] xfs_repair: skip freelist scan of corrupt agf in no-modify mode
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Sat, 9 Mar 2013 20:00:41 +1100
Cc: Eric Sandeen <sandeen@xxxxxxxxxxx>, Ole Tange <tange@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <513A4A9B.3050802@xxxxxxx>
References: <51313DE8.5080104@xxxxxxxxxxx> <51326DC0.8030403@xxxxxxxxxxx> <513A4A9B.3050802@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Mar 08, 2013 at 02:31:23PM -0600, Rich Johnston wrote:
> This version looks good. ;)
> 
> Reviewed-by: Rich Johnston <rjohnston@xxxxxxx>
> 
> This has been committed.

Except that all review comments have not been addressed. i.e there
are two places that have the same bug and they haven't been fixed.

It's great that you want to commit quickly, but commits should not
happen while there are unaddressed issues still outstanding....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>