xfs
[Top] [All Lists]

Re: [PATCH V2] xfs_repair: skip freelist scan of corrupt agf in no-modif

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH V2] xfs_repair: skip freelist scan of corrupt agf in no-modify mode
From: Rich Johnston <rjohnston@xxxxxxx>
Date: Fri, 8 Mar 2013 14:31:23 -0600
Cc: xfs-oss <xfs@xxxxxxxxxxx>, Ole Tange <tange@xxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <51326DC0.8030403@xxxxxxxxxxx>
References: <51313DE8.5080104@xxxxxxxxxxx> <51326DC0.8030403@xxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20120615 Thunderbird/13.0.1
This version looks good. ;)

Reviewed-by: Rich Johnston <rjohnston@xxxxxxx>

This has been committed.

commit 7e8e3cce00f38ee1533df0e7bda6bcb584b03e96
Author: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date:   Sat Mar 2 21:23:12 2013 +0000

xfsprogs: xfs_repair skip freelist scan of corrupt agf in no-modify mode

    In xfs_repair's no-modify mode (-n), verify_set_agf doesn't fix up
    bad freelist blocks that it finds.  When we get to scan_freelist,
    this can wreak havoc if, for example, first > last and the loop
    never exits; we index agfl->agfl_bno[i] off into the weeds.

    To fix this, re-check the values in no-modify mode, and if
    they're off, warn about it and skip the scan.



<Prev in Thread] Current Thread [Next in Thread>