xfs
[Top] [All Lists]

Re: [PATCH] xfstests 273: fix a typo

To: dsterba@xxxxxxx, Wang Sheng-Hui <shhuiw@xxxxxxxxx>, xfs@xxxxxxxxxxx
Subject: Re: [PATCH] xfstests 273: fix a typo
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 8 Mar 2013 09:48:32 +1100
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130307110600.GJ21081@xxxxxxxxxxxxx>
References: <512DAC1A.2040601@xxxxxxxxx> <20130306232222.GF21081@xxxxxxxxxxxxx> <20130307033849.GB6369@dastard> <20130307110600.GJ21081@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Mar 07, 2013 at 12:06:01PM +0100, David Sterba wrote:
> On Thu, Mar 07, 2013 at 02:38:49PM +1100, Dave Chinner wrote:
> > On Thu, Mar 07, 2013 at 12:22:22AM +0100, David Sterba wrote:
> > > On Wed, Feb 27, 2013 at 02:47:54PM +0800, Wang Sheng-Hui wrote:
> > > > -       cp -r $SCRATCH_MNT/origin $SCRATCH_MNT/sub_$_suffix >$seq.full 
> > > > 2>&1
> > > > +       cp -r $SCRATCH_MNT/origin $SCRATCH_MNT/sub_$_suffix >>$seq.full 
> > > > 2>&1
> 
> This is quote from the mail, but the merged patch does something else.
> 
> > >     +./273: line 95: syntax error near unexpected token `&'
> > >     +./273: line 95: `  cp -r $SCRATCH_MNT/origin 
> > > $SCRATCH_MNT/sub_$_suffix >$seq.full 2>>&1'
> > >     +umount: /dev/sda9: not mounted
> 
> > that seems rather strange. The patch does this:
> > 
> >     ....sub_$_suffix >>$seq.full 2>&1
> 
> http://oss.sgi.com/cgi-bin/gitweb.cgi?p=xfs/cmds/xfstests.git;a=commitdiff;h=0c5e67e46e476b70290033efc7feb784f7ecbab1;hp=08557e219c12e573be459407033495899f46967a

Oh....

> ---
> 
> > and the error output you see is
> > 
> >     ....sub_$_suffix >$seq.full 2>>&1
> > 
> > So it doesn't look lie you are running with the change that is
> > actually in the patch...
> 
> There's a difference between the patch in mail and what has been merged, that
> can happen, but I wonder why it works on your side.

.... because I haven't updated to the latest xfstests master branch
yet - I'm running with the patch from the list applied. I didn't
realise you were running from the main repo, and that the commit was
busted...

Cheers,

Dave.

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>