xfs
[Top] [All Lists]

Re: [PATCH] xfstests 273: fix a typo

To: dsterba@xxxxxxx, Wang Sheng-Hui <shhuiw@xxxxxxxxx>, xfs@xxxxxxxxxxx
Subject: Re: [PATCH] xfstests 273: fix a typo
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 7 Mar 2013 14:38:49 +1100
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130306232222.GF21081@xxxxxxxxxxxxx>
References: <512DAC1A.2040601@xxxxxxxxx> <20130306232222.GF21081@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Mar 07, 2013 at 12:22:22AM +0100, David Sterba wrote:
> On Wed, Feb 27, 2013 at 02:47:54PM +0800, Wang Sheng-Hui wrote:
> > Make the porter log cp failure into $seq.full by appending, not overwriting,
> > which can help debug.
> > 
> > Signed-off-by: Wang Sheng-Hui <shhuiw@xxxxxxxxx>
> > ---
> >  273 |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/273 b/273
> > index 67f3d6b..639e280 100755
> > --- a/273
> > +++ b/273
> > @@ -92,7 +92,7 @@ _porter()
> >             exit
> >     fi
> > 
> > -   cp -r $SCRATCH_MNT/origin $SCRATCH_MNT/sub_$_suffix >$seq.full 2>&1
> > +   cp -r $SCRATCH_MNT/origin $SCRATCH_MNT/sub_$_suffix >>$seq.full 2>&1
> 
> This gives me
> 
> 273 154s ...    [20:05:00] [20:05:01] - output mismatch (see 273.out.bad)
>     --- 273.out 2011-11-11 15:13:46.000000000 +0100
>     +++ 273.out.bad     2013-03-06 20:05:01.000000000 +0100
>     @@ -1,4 +1,4 @@
>      QA output created by 273
>     -------------------------------
>     -start the workload
>     -------------------------------
>     +./273: line 95: syntax error near unexpected token `&'
>     +./273: line 95: `  cp -r $SCRATCH_MNT/origin $SCRATCH_MNT/sub_$_suffix 
> >$seq.full 2>>&1'
>     +umount: /dev/sda9: not mounted

that seems rather strange. The patch does this:

        ....sub_$_suffix >>$seq.full 2>&1

and the error output you see is

        ....sub_$_suffix >$seq.full 2>>&1

So it doesn't look lie you are running with the change that is
actually in the patch...
>      ...
>      (Run 'diff -u 273.out 273.out.bad' to see the entire diff)
> ---
> 
> The script calls /bin/bash, my version says
> GNU bash, version 4.1.10(1)-release

Wroks fine here, with:

GNU bash, version 4.2.37(1)-release

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>