xfs
[Top] [All Lists]

Re: [PATCH] xfstests: Fix hang when mkfs.btrfs isn't present

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: Fix hang when mkfs.btrfs isn't present
From: Rich Johnston <rjohnston@xxxxxxx>
Date: Wed, 6 Mar 2013 07:03:01 -0600
Cc: Eric Sandeen <sandeen@xxxxxxxxxx>, Stefan Behrens <sbehrens@xxxxxxxxxxxxxxxx>, linux-btrfs <linux-btrfs@xxxxxxxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <513674B2.9030900@xxxxxxxxxxx>
References: <512D1E3E.9050907@xxxxxxxxxx> <513674B2.9030900@xxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20120615 Thunderbird/13.0.1
This patch has been committed.

Thanks
--Rich

commit 52f4953ac4a377f9f7fc870d2a81f30c3e5d3c7f
Author: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date:   Tue Mar 5 22:41:54 2013 +0000

    xfstests: Fix hang when mkfs.btrfs isn't present

    My earlier patch (xfstests: handle new mkfs.btrfs -f option cleanly)
    had a flaw in that if set_prog_path mkfs.btrfs returns nothing,
    the grep will hang.

    Test for that case to avoid it, and just return the empty string
    in that case.

    Reported-by: Rich Johnston <rjohnston@xxxxxxx>
    Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
    Reviewed-by: Rich Johnston <rjohnston@xxxxxxx>
    Signed-off-by: Rich Johnston <rjohnston@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>