xfs
[Top] [All Lists]

Re: [PATCH 07/16] xfs: add CRC checks for quota blocks

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 07/16] xfs: add CRC checks for quota blocks
From: Ben Myers <bpm@xxxxxxx>
Date: Tue, 5 Mar 2013 14:36:15 -0600
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1361755901-12453-8-git-send-email-david@xxxxxxxxxxxxx>
References: <1361755901-12453-1-git-send-email-david@xxxxxxxxxxxxx> <1361755901-12453-8-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
Hi Dave,

On Mon, Feb 25, 2013 at 12:31:32PM +1100, Dave Chinner wrote:
> From: Christoph Hellwig <hch@xxxxxx>
> 
> Use the reserved space in struct xfs_dqblk to store a UUID and a crc
> for the quota blocks.
> 
> [dchinner@xxxxxxxxxx] Add a LSN field and update for current verifier
> infrastructure.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Been over this and it looks fine.

> @@ -897,6 +910,10 @@ xfs_qm_dqiter_bufs(
>               if (error)
>                       break;
>  
> +             /*
> +              * XXX(hch): need to figure out if it makes sense to validate
> +              *           the CRC here.
> +              */

What's you're opinion on this?

-Ben

<Prev in Thread] Current Thread [Next in Thread>