xfs
[Top] [All Lists]

Re: [PATCH] xfstests: use native definition of O_DIRECT flag

To: Eric Whitney <enwlinux@xxxxxxxxx>
Subject: Re: [PATCH] xfstests: use native definition of O_DIRECT flag
From: Rich Johnston <rjohnston@xxxxxxx>
Date: Tue, 5 Mar 2013 14:09:22 -0600
Cc: <xfs@xxxxxxxxxxx>, <linux-ext4@xxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130226210322.GB5275@wallace>
References: <20130226210322.GB5275@wallace>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20120615 Thunderbird/13.0.1
This patch has been committed.

Thanks
--Rich

commit 5825ecd3b99ed8c177895d5e6a830133fed384ea
Author: Eric Whitney <enwlinux@xxxxxxxxx>
Date:   Tue Feb 26 21:03:22 2013 +0000

    xfstests: use native definition of O_DIRECT flag

    The definition of O_DIRECT in src/trunc.c causes xfstest 125 to fail
    when run on a Pandaboard.  On ARM, the value used (0x040000) is
O_DIRECTORY rather than O_DIRECT as it is on x86. Prefer the platform's
    native definition of O_DIRECT supplied by fcntl.h if available.  Also,
    fix a couple of error messages to properly reflect their context.

    Signed-off-by: Eric Whitney <enwlinux@xxxxxxxxx>
    Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
    Signed-off-by: Rich Johnston <rjohnston@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] xfstests: use native definition of O_DIRECT flag, Rich Johnston <=