xfs
[Top] [All Lists]

Re: [PATCH V3] xfstests: don't remove trailing zeros from integers

To: Eric Whitney <enwlinux@xxxxxxxxx>
Subject: Re: [PATCH V3] xfstests: don't remove trailing zeros from integers
From: Rich Johnston <rjohnston@xxxxxxx>
Date: Tue, 5 Mar 2013 13:49:22 -0600
Cc: <xfs@xxxxxxxxxxx>, <sandeen@xxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130305191748.GB3930@wallace>
References: <20130305191748.GB3930@wallace>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20120615 Thunderbird/13.0.1
This patch has been committed.

Thanks
--Rich


commit edce9e677fda49ca20d6059248937ab4af65d053
Author: Eric Whitney <enwlinux@xxxxxxxxx>
Date:   Tue Mar 5 19:17:48 2013 +0000

    xfstests: don't remove trailing zeros from integers

    _within_tolerance strips trailing zeros from the min and max range
    values it outputs.  This leads to damage if the min or max value is
    an integer containing trailing zeros rather than a real number with
    a fractional part containing trailing zeros. Xfstest 289 can exhibit
    this problem when its input is out of range.  Modify the code so it
    will only remove trailing zeros found after a decimal point.

    V1->V2: Remove decimal points not followed by digits
    V2->V3: Per Dave Chinner, simplify by using multiple sed expressions

    Signed-off-by: Eric Whitney <enwlinux@xxxxxxxxx>
    Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>
    Signed-off-by: Rich Johnston <rjohnston@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>