xfs
[Top] [All Lists]

Re: [PATCH V2] xfstests: don't remove trailing zeros from integers

To: Rich Johnston <rjohnston@xxxxxxx>
Subject: Re: [PATCH V2] xfstests: don't remove trailing zeros from integers
From: Eric Whitney <enwlinux@xxxxxxxxx>
Date: Tue, 5 Mar 2013 14:31:43 -0500
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, Eric Whitney <enwlinux@xxxxxxxxx>, sandeen@xxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=MShdQetjwyS6lKxvvOtGve/uspO9O7WBnq1cPJFBckA=; b=AKLL1xA1eNHDiwypK+A4uUTYM4V67ZyvMpEpWveqRrow+tiwgmcYKqrHSO58e/JGyT X53YLSXTEQDXxG0GVTBsxvbzQQV2gOA8Bo48I5bvoIXvMMpEW47EdWzie+oyXjUKv6XH vemvY3+8sbr1Rg4TYoYuQmxl2MGeAasctWRL7a7W+4J92Kg6PhTLCSgG4r31Dr6i5isN f9wH3n7J4/yDPcdYIorvgY1VezkpTHY3ybaPXjDZX+g91HccgxOiEV7dFw+e0r2mPP3o 5zs92o2e/XLYCeZk4HkD5VCT8+OQfM7g+Al4ydbCWVpSkepgDtPLC5PKUl91BIuOp9il p88g==
In-reply-to: <5136458D.4070803@xxxxxxx>
References: <20130301180158.GC6449@wallace> <20130301203026.GC23616@dastard> <5136458D.4070803@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
* Rich Johnston <rjohnston@xxxxxxx>:
> On 03/01/2013 02:30 PM, Dave Chinner wrote:
> >On Fri, Mar 01, 2013 at 01:01:58PM -0500, Eric Whitney wrote:
> >>_within_tolerance strips trailing zeros from the min and max range
> >>values it outputs.  This leads to damage if the min or max value is
> >>an integer containing trailing zeros rather than a real number with
> >>a fractional part containing trailing zeros. Xfstest 289 can exhibit
> >>this problem when its input is out of range.  Modify the code so it
> >>will only remove trailing zeros found after a decimal point, and
> >>remove decimal points not followed by digits.
> >>
> >>Signed-off-by: Eric Whitney <enwlinux@xxxxxxxxx>
> >>---
> >>  common.filter |    7 +++++--
> >>  1 file changed, 5 insertions(+), 2 deletions(-)
> >>
> >>diff --git a/common.filter b/common.filter
> >>index 9e4c90c..bfc800b 100644
> >>--- a/common.filter
> >>+++ b/common.filter
> >>@@ -106,8 +106,11 @@ EOF
> >>
> >>    # fix up min, max precision for output
> >>    # can vary for 5.3, 6.2
> >>-  _min=`echo $_min | sed -e 's/0*$//'` # get rid of trailling zeroes
> >>-  _max=`echo $_max | sed -e 's/0*$//'` # get rid of trailling zeroes
> >>+
> >>+  # remove any trailing zeroes from min, max if they have fractional parts
> >>+  # and then remove any decimal points not followed by digits
> >>+  _min=`echo $_min | sed -e '/\./s/0*$//' | sed -e 's/\.$//'`
> >>+  _max=`echo $_max | sed -e '/\./s/0*$//' | sed -e 's/\.$//'`
> 
> I like Dave's suggestion to change it to the following, what do you
> think Eric?

I just posted a V3 containing Dave's simplification.  I'd hoped there
would be something like that, and much appreciate the suggestion.

Thanks,
Eric


> 
> +  _min=`echo $_min | sed -e '/\./s/0*$//' -e 's/\.$//'` # get rid
> of trailing zeros
> +  _max=`echo $_max | sed -e '/\./s/0*$//' -e 's/\.$//'` # get rid
> of trailing zeros
> 
> Regards
> --Rich
> 
> >
> >You can do this with a single sed invocation via multiple
> >expressions:
> >
> >$ echo 200.00 | sed -e '/\./s/0*$//' -e 's/\.$//'
> >200
> >$
> >
> >Cheers,
> >
> >Dave.
> >
> 
> 

<Prev in Thread] Current Thread [Next in Thread>