xfs
[Top] [All Lists]

Re: [PATCH] Do not check ocfs2

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] Do not check ocfs2
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 4 Mar 2013 11:42:29 +1100
Cc: Richard Weinberger <richard@xxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <5133D573.3050106@xxxxxxxxxxx>
References: <1362269150-21478-1-git-send-email-richard@xxxxxx> <20130303011917.GI23616@dastard> <20130303100254.500b076f@xxxxxxxxxxxxxxxxxxxxx> <5133C900.9050300@xxxxxxxxxxx> <20130303231905.0efd6d08@xxxxxxxxxxxxxxxxxxxxx> <5133D15A.9010600@xxxxxxxxxxx> <20130303235341.7470085e@xxxxxxxxxxxxxxxxxxxxx> <5133D573.3050106@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Sun, Mar 03, 2013 at 04:57:55PM -0600, Eric Sandeen wrote:
> On 3/3/13 4:53 PM, Richard Weinberger wrote:
> 
> >> Anyway, what if you did something more along the lines of [pseudocode]
> >>
> >> ocfs2)
> >>    if mounted.ocfs2 -f $TEST-DEV | frob_as_necessary[1]
> >>            ;
> >>    else
> >>            fsck.ocfs2 $TEST-DEV
> >>    fi
> >>    ;;
> >>
> >> so that *if* it's mounted on some other node, the fsck won't run.
> >> That has downsides as Dave mentioned, but for the case where the
> >> xfstests node is the only one with it in use, it'll still do the
> >> beneficial consistency check.
> >>
> >> Just tweaking the fsck action bsed on *if* it's mounted (or,
> >> maybe, if the node is in a cluster?) might be a more generic solution
> >> that is widely applicable to all ocfs2 test environments.
> > 
> > Good point. mounted.ocfs2 really makes sense. I'll implement this on my
> > test suite and submit a new patch.
> 
> Sounds good to me.
> 
> It'd be most preferable to do a cluster-wide unmount and fsck,

Which makes no sense to me, because ./check will then do a cluster
wide unmount as it runs the test harness initialisation. Hence all
the subsequent tests will run with the filesystem only mounted on
the local node....

Really, xfstests is not designed for testing cluster filesystems in
clustered environments. If we really want to support clustered
filesystems and cluster wide operations, then we need to think
about how to architect multi-host support into xfstests sanely.
Clustered filesystems are not the only people that could make use of
such functionality (NFS and CIFS come to mind).... ;)

Cheers,

Dave/
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>