xfs
[Top] [All Lists]

Re: [PATCH] Do not check ocfs2

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] Do not check ocfs2
From: Richard Weinberger <richard@xxxxxx>
Date: Sun, 3 Mar 2013 10:02:54 +0100
Cc: xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130303011917.GI23616@dastard>
References: <1362269150-21478-1-git-send-email-richard@xxxxxx> <20130303011917.GI23616@dastard>
Am Sun, 3 Mar 2013 12:19:17 +1100
schrieb Dave Chinner <david@xxxxxxxxxxxxx>:

> On Sun, Mar 03, 2013 at 01:05:50AM +0100, Richard Weinberger wrote:
> > We cannot run fsck.ocfs2 because the file system
> > is most likely mounted on another node.
> 
> This patch means that ocfs2 filesystems are *never* checked for
> consistency, even when you are testing them with exclusive local
> access. That defeats a primary function of xfstests - ensuring that
> the tests run do no corrupt the filesystem.
> 
> Besides, why would you be running xfstests on a filesystem that is
> mounted on multiple nodes? Yes, ocfs2 is a cluster filesystem, but
> xfstests is designed to test local filesystem behaviour and is
> completely cluster naive. Hence having multiple nodes mount the
> filesystem that is being tested by xfstests does not serve any
> purpose at all. Further, turning off consistency checking for those
> that are running ocfs2 testing on single nodes means that testing is
> now mostly wasted as the majority of problems that can occur are no
> longer detectable....

Using xfstests I was able to trigger dlm issues in ocfs2.
I ran xfstests on one node and other nodes had it mounted too.
To ensure that fsck.ocfs2 will not corrupt the filesystem I've applied
this patch.

If you don't like the patch I'm perfectly fine with that.
Maybe it makes more sense to add a feature to xfstests which unmounts
the ocfs2 filesystem on all nodes (using SSH), then it is allowed to
run fsck.ocfs2.

Thanks,
//richard

<Prev in Thread] Current Thread [Next in Thread>