[Top] [All Lists]

Re: [PATCH] Do not check ocfs2

To: Richard Weinberger <richard@xxxxxx>
Subject: Re: [PATCH] Do not check ocfs2
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Sun, 3 Mar 2013 12:19:17 +1100
Cc: xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1362269150-21478-1-git-send-email-richard@xxxxxx>
References: <1362269150-21478-1-git-send-email-richard@xxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Sun, Mar 03, 2013 at 01:05:50AM +0100, Richard Weinberger wrote:
> We cannot run fsck.ocfs2 because the file system
> is most likely mounted on another node.

This patch means that ocfs2 filesystems are *never* checked for
consistency, even when you are testing them with exclusive local
access. That defeats a primary function of xfstests - ensuring that
the tests run do no corrupt the filesystem.

Besides, why would you be running xfstests on a filesystem that is
mounted on multiple nodes? Yes, ocfs2 is a cluster filesystem, but
xfstests is designed to test local filesystem behaviour and is
completely cluster naive. Hence having multiple nodes mount the
filesystem that is being tested by xfstests does not serve any
purpose at all. Further, turning off consistency checking for those
that are running ocfs2 testing on single nodes means that testing is
now mostly wasted as the majority of problems that can occur are no
longer detectable....


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>