xfs
[Top] [All Lists]

[PATCH] xfstests: don't remove trailing zeros from integers

To: xfs@xxxxxxxxxxx
Subject: [PATCH] xfstests: don't remove trailing zeros from integers
From: Eric Whitney <enwlinux@xxxxxxxxx>
Date: Thu, 28 Feb 2013 19:26:37 -0500
Cc: sandeen@xxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:date:from:to:cc:subject:message-id:mime-version :content-type:content-disposition:user-agent; bh=W7E5oozbHu6m7inxWQA7IVLWjDrJC5sznfZxSoAyvB4=; b=nTA71TgUqUg+ecC/dCLZUNMpvjf9rzkDBOJGF1QnQN2w7cOqFT9IO4U6oAjHEfqtxS GZTmTJ8L+7Chtdul5k01ZJFgFmvCHZzTc0M/oXNKp3tbVR2/5TcW8y+lOt/yMH8OcHyp 1ZyBQ+C2oaDuZFm0LI7IQU+vWepeJZkpmhVzLCnUNc2q3bCKl6GS9x/XBotPrQjbItEM itnljAWP3/1IApNLTxNZgKRsQRaZoiW2nrmZO34sVfUGpt8xVMwGSaTVF+5aVc31LBn/ n/BPr6Pndc9QXQ42FJxvsW4janou7JFsG8HxZLABxdYCVpBU+dcVDHQtNoflY4AHqRWa loMg==
User-agent: Mutt/1.5.21 (2010-09-15)
_within_tolerance strips trailing zeros from the min and max range
values it outputs.  This leads to damage if the min or max value is
an integer containing trailing zeros rather than a real number with
a fractional part containing trailing zeros. Xfstest 289 can exhibit
this problem when its input is out of range.  Modify the code so it
will only remove trailing zeros found after a decimal point.

Signed-off-by: Eric Whitney <enwlinux@xxxxxxxxx>
---
 common.filter |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/common.filter b/common.filter
index 9e4c90c..1df2f97 100644
--- a/common.filter
+++ b/common.filter
@@ -106,8 +106,10 @@ EOF
 
   # fix up min, max precision for output
   # can vary for 5.3, 6.2
-  _min=`echo $_min | sed -e 's/0*$//'` # get rid of trailling zeroes
-  _max=`echo $_max | sed -e 's/0*$//'` # get rid of trailling zeroes
+
+  # remove any trailing zeroes from min, max if they have fractional parts
+  _min=`echo $_min | sed -e '/\./s/0*$//'`
+  _max=`echo $_max | sed -e '/\./s/0*$//'`
 
   if [ $_in_range -eq 1 ] 
   then
-- 
1.7.10.4

<Prev in Thread] Current Thread [Next in Thread>