xfs
[Top] [All Lists]

Re: [PATCH] xfstests 276: fix error 'FIBMAP: Invalid argument'

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests 276: fix error 'FIBMAP: Invalid argument'
From: Eric Sandeen <sandeen@xxxxxxxxxx>
Date: Wed, 27 Feb 2013 17:11:01 -0600
Cc: Wang Sheng-Hui <shhuiw@xxxxxxxxx>, xfstests <xfs@xxxxxxxxxxx>, linux-btrfs@xxxxxxxxxxxxxxx, list.btrfs@xxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130227230443.GB5551@dastard>
References: <512DB284.1090806@xxxxxxxxx> <20130227230443.GB5551@dastard>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130216 Thunderbird/17.0.3
On 2/27/13 5:04 PM, Dave Chinner wrote:
> On Wed, Feb 27, 2013 at 03:15:16PM +0800, Wang Sheng-Hui wrote:
>> Btrfs doesn't support FIEMAP_FLAG_XATTR, which is enabled by
>> -x option of filefrag, and will fail with
>>      'FIBMAP: Invalid argument'
>> for 'filefrag -vx'. 'filefrag -vx' fails on btrfs with
>>     'FIEMAP failed with unsupported flags 2'
>> Remove the '-x' option.
>>
>> Signed-off-by: Wang Sheng-Hui <shhuiw@xxxxxxxxx>
> 
> I can see that this changes what gets dumped into the $seq.full
> file, but it seems to me that also changes the extent list returned
> to the checking functions. So either the test previously worked and
> now it fails with this change, or the test never worked and now it
> does, or perhaps something else?

Agreed - I wondered as well.

> IOWs, I can't tell why you want to change this from the patch
> description, hence I don't know if the original behaviour was
> intentional or not.  Can you say describe what the overall effect of
> the change is in the commit description?

It looks like -x is only recently rejected:

commit 05dadc09f52ad5a631da1aa8767c5b80e121f0c4
Author: Tsutomu Itoh <t-itoh@xxxxxxxxxxxxxx>
Date:   Thu Nov 29 05:08:26 2012 +0000

    Btrfs: add fiemap's flag check

+#define BTRFS_FIEMAP_FLAGS     (FIEMAP_FLAG_SYNC)

+       ret = fiemap_check_flags(fieinfo, BTRFS_FIEMAP_FLAGS);

-Eric

> Cheers,
> 
> Dave.
> 

<Prev in Thread] Current Thread [Next in Thread>