[Top] [All Lists]

Re: [PATCH] xfstests 276: fix error 'FIBMAP: Invalid argument'

To: Wang Sheng-Hui <shhuiw@xxxxxxxxx>
Subject: Re: [PATCH] xfstests 276: fix error 'FIBMAP: Invalid argument'
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 28 Feb 2013 10:04:43 +1100
Cc: xfstests <xfs@xxxxxxxxxxx>, linux-btrfs@xxxxxxxxxxxxxxx, list.btrfs@xxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <512DB284.1090806@xxxxxxxxx>
References: <512DB284.1090806@xxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Feb 27, 2013 at 03:15:16PM +0800, Wang Sheng-Hui wrote:
> Btrfs doesn't support FIEMAP_FLAG_XATTR, which is enabled by
> -x option of filefrag, and will fail with
>       'FIBMAP: Invalid argument'
> for 'filefrag -vx'. 'filefrag -vx' fails on btrfs with
>     'FIEMAP failed with unsupported flags 2'
> Remove the '-x' option.
> Signed-off-by: Wang Sheng-Hui <shhuiw@xxxxxxxxx>

I can see that this changes what gets dumped into the $seq.full
file, but it seems to me that also changes the extent list returned
to the checking functions. So either the test previously worked and
now it fails with this change, or the test never worked and now it
does, or perhaps something else?

IOWs, I can't tell why you want to change this from the patch
description, hence I don't know if the original behaviour was
intentional or not.  Can you say describe what the overall effect of
the change is in the commit description?


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>