[Top] [All Lists]

Re: [RFC] [PATCH 0/18] xfstests: move tests out of top level

To: Theodore Ts'o <tytso@xxxxxxx>
Subject: Re: [RFC] [PATCH 0/18] xfstests: move tests out of top level
From: Ben Myers <bpm@xxxxxxx>
Date: Mon, 25 Feb 2013 21:22:34 -0600
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxxx>, Mark Tinguely <tinguely@xxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130226002743.GA7007@xxxxxxxxx>
References: <5032ABBD.80504@xxxxxxx> <20120820224306.GF19235@dastard> <20120821163337.GC29979@xxxxxxx> <20120821220926.GP19235@dastard> <20120822191642.GF29979@xxxxxxx> <20120822234219.GR19235@dastard> <20120823170025.GG29979@xxxxxxx> <512B8834.30805@xxxxxxxxxxx> <20130225215220.GG5551@dastard> <20130226002743.GA7007@xxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
Hi Ted,

On Mon, Feb 25, 2013 at 07:27:43PM -0500, Theodore Ts'o wrote:
> If the SGI folks are still resistant to removing the bitrotted
> performance tests,

I have no objection to removing the bitrotted performance tests, so long
as we can come to an agreement on a replacement.

> I have a much simpler patch which we've been using
> inside Google for a while now which allows for alphanumeric tests
> "numbers".  This allows us to use tests such as "g001", "g002", etc.,
> without having to worry about test number collisions fom upstream.
> That would also be useful for ext4 since we could keep a fork of
> xfstests with e001, e002, e003, etc., while we wait for the tests to
> be reviewed for inclusing in the SGI tree.

Few of the xfs geeks are well versed on ext4.  Could members of the ext4
crew extend Reviewed-bys on ext4 relevant patches?  I think that could
go a long way toward speeding things up, although it doesn't resolve the
renumbering issue.

> I hadn't bothered submitting it since it was clear Dave's changes was
> better, but the advantage of the hack we've been using inside Google
> is that it's a much less intrusive patch.
> The reason why I'm interested in having e001, e002, etc., patches is
> that at the moment we've got a number of people using private xfstests
> repositories and reporting regressions based on them.  They are using
> numbers such as "301", which is very confusing since they aren't
> upstream and there's a chance the test may get renumbered by the time
> it does go upstream.
> The advantage of using a named-based system, or using patch numbers
> such as e001, g001, etc., is that it makes it a lot easier to keep
> track of tests that haven't made it upstream to the xfstests git
> repository.

Ew.  The renumbering issue has been inconvenient for xfs geeks too.  I'm
all for changing to a name-based system.  Doing so is not mutually
exclusive with having a performance test capability in xfstests.

I think the biggest challenge right now is to get Dave's series to apply
again to today's tree.  But if you'd like to post your patch, I'd be
happy to look at it.

> Cheers,
>                                               - Ted
> P.S.  I'm happy to review Dmitry's patches if it will help, but I
> wasn't sure whether you were looking for someone more experienced with
> the xfstests code base to review them.

Please do.  Reviews by ext4/btrfs experts are welcome.  So are ext4 and
btrfs specific tests.


<Prev in Thread] Current Thread [Next in Thread>