[Top] [All Lists]

Re: [RFC] [PATCH 0/18] xfstests: move tests out of top level

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [RFC] [PATCH 0/18] xfstests: move tests out of top level
From: Theodore Ts'o <tytso@xxxxxxx>
Date: Mon, 25 Feb 2013 19:27:43 -0500
Cc: Eric Sandeen <sandeen@xxxxxxxxxxx>, Ben Myers <bpm@xxxxxxx>, Mark Tinguely <tinguely@xxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130225215220.GG5551@dastard>
References: <1343294892-20991-1-git-send-email-david@xxxxxxxxxxxxx> <5032ABBD.80504@xxxxxxx> <20120820224306.GF19235@dastard> <20120821163337.GC29979@xxxxxxx> <20120821220926.GP19235@dastard> <20120822191642.GF29979@xxxxxxx> <20120822234219.GR19235@dastard> <20120823170025.GG29979@xxxxxxx> <512B8834.30805@xxxxxxxxxxx> <20130225215220.GG5551@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
If the SGI folks are still resistant to removing the bitrotted
performance tests, I have a much simpler patch which we've been using
inside Google for a while now which allows for alphanumeric tests
"numbers".  This allows us to use tests such as "g001", "g002", etc.,
without having to worry about test number collisions fom upstream.

That would also be useful for ext4 since we could keep a fork of
xfstests with e001, e002, e003, etc., while we wait for the tests to
be reviewed for inclusing in the SGI tree.

I hadn't bothered submitting it since it was clear Dave's changes was
better, but the advantage of the hack we've been using inside Google
is that it's a much less intrusive patch.

The reason why I'm interested in having e001, e002, etc., patches is
that at the moment we've got a number of people using private xfstests
repositories and reporting regressions based on them.  They are using
numbers such as "301", which is very confusing since they aren't
upstream and there's a chance the test may get renumbered by the time
it does go upstream.

The advantage of using a named-based system, or using patch numbers
such as e001, g001, etc., is that it makes it a lot easier to keep
track of tests that haven't made it upstream to the xfstests git


                                                - Ted

P.S.  I'm happy to review Dmitry's patches if it will help, but I
wasn't sure whether you were looking for someone more experienced with
the xfstests code base to review them.

<Prev in Thread] Current Thread [Next in Thread>