xfs
[Top] [All Lists]

Re: [PATCH 1/2] xfstests 298: check ctime updates for setfacl

To: Eryu Guan <eguan@xxxxxxxxxx>
Subject: Re: [PATCH 1/2] xfstests 298: check ctime updates for setfacl
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Sat, 23 Feb 2013 12:37:29 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1361516369-7480-1-git-send-email-eguan@xxxxxxxxxx>
References: <1361516369-7480-1-git-send-email-eguan@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Feb 22, 2013 at 02:59:28PM +0800, Eryu Guan wrote:
> Check if ctime is updated and written to disk after setfacl
> 
> Regression test for the following extN commits
> c6ac12a ext4: update ctime when changing the file's permission by setfacl
> 30e2bab ext3: update ctime when changing the file's permission by setfacl
> 523825b ext2: update ctime when changing the file's permission by setfacl
> 
> Signed-off-by: Eryu Guan <eguan@xxxxxxxxxx>
.....

Only thing I'd add to this is an indication that an empty output
file is what is expected when the test passes. i.e. add this:

echo "Silence is golden"

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>