[Top] [All Lists]

Re: [PATCH] xfs: fix potential infinite loop in xfs_iomap_prealloc_size(

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH] xfs: fix potential infinite loop in xfs_iomap_prealloc_size()
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Sat, 23 Feb 2013 11:56:45 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1361557976-54981-1-git-send-email-bfoster@xxxxxxxxxx>
References: <1361557976-54981-1-git-send-email-bfoster@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Feb 22, 2013 at 01:32:56PM -0500, Brian Foster wrote:
> If freesp == 0, we could end up in an infinite loop while squashing
> the preallocation. Break the loop when we've killed the prealloc
> entirely.
> Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx>

Looks good.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>