xfs
[Top] [All Lists]

Re: [PATCH v2] xfs_mkfs: Do not discard if '-N' is provided

To: Lukas Czerner <lczerner@xxxxxxxxxx>
Subject: Re: [PATCH v2] xfs_mkfs: Do not discard if '-N' is provided
From: Ben Myers <bpm@xxxxxxx>
Date: Thu, 14 Feb 2013 16:07:26 -0600
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1360683870-4874-1-git-send-email-lczerner@xxxxxxxxxx>
References: <1360683870-4874-1-git-send-email-lczerner@xxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Tue, Feb 12, 2013 at 04:44:30PM +0100, Lukas Czerner wrote:
> When '-N' is specified we really should not write anything to the
> device, neither we should attempt to discard the device.
> 
> This commit fixes xfs_mkfs to not attempt to discard the device in the
> case user specified '-N' flag.
> 
> Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx>

Wow.  That's bad.

Reviewed-by: Ben Myers <bpm@xxxxxxx>

Applied.  Thanks Lukas!

<Prev in Thread] Current Thread [Next in Thread>