xfs
[Top] [All Lists]

Re: [PATCH] xfs_mkfs: Do not discard if '-N' is provided

To: LukÃÅ Czerner <lczerner@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs_mkfs: Do not discard if '-N' is provided
From: Ben Myers <bpm@xxxxxxx>
Date: Thu, 14 Feb 2013 13:19:52 -0600
Cc: Eric Sandeen <sandeen@xxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <alpine.LFD.2.00.1302121635070.2315@(none)>
References: <1360670381-19838-1-git-send-email-lczerner@xxxxxxxxxx> <511A5BAA.5000203@xxxxxxxxxxx> <alpine.LFD.2.00.1302121635070.2315@(none)>
User-agent: Mutt/1.5.20 (2009-06-14)
Hey Lukas,

On Tue, Feb 12, 2013 at 04:37:37PM +0100, LukÃÅ Czerner wrote:
> On Tue, 12 Feb 2013, Eric Sandeen wrote:
> 
> > Date: Tue, 12 Feb 2013 09:11:38 -0600
> > From: Eric Sandeen <sandeen@xxxxxxxxxxx>
> > To: Lukas Czerner <lczerner@xxxxxxxxxx>
> > Cc: xfs@xxxxxxxxxxx
> > Subject: Re: [PATCH] xfs_mkfs: Do not discard if '-N' is provided
> > 
> > On 2/12/13 5:59 AM, Lukas Czerner wrote:
> > > When '-N' is specified we really should not write anything to the
> > > device, neither we should attempt to discard the device.
> > > 
> > > This commit fixes xfs_mkfs to not attempt to discard the device in the
> > > case user specified '-N' flag.
> > 
> > Thanks, and yes - ouch, this shouldn't happen with -N, that's bad!
> > 
> > But it doesn't look like this is against the current git tree,
> > it applies only with a lot of fuzz & offsets.
> 
> Ah, I've been using 
> 
> git://git.kernel.org/pub/scm/fs/xfs/xfsprogs-dev.git
> 
> and I can remember that it's not the first time I've realized that I
> am using wrong repo. Obviously i am not paying a lot of attention to
> the xfs channel, but does this keep changing, or is it just me ? :)

It changed just twice, AFAIK.

Christoph, could you clean up the kernel.org trees to help resolve the
confusion?

> Will resend the patch based on the
> 
> git://oss.sgi.com/xfs/cmds/xfsprogs.git

This is the right place, thanks.

Regards,
        Ben

<Prev in Thread] Current Thread [Next in Thread>