[Top] [All Lists]

Re: [PATCH] xfs_mkfs: wipe old signatures from the device

To: Dave Howorth <dhoworth@xxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs_mkfs: wipe old signatures from the device
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Thu, 14 Feb 2013 13:17:12 -0600
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <511CCE67.5010402@xxxxxxxxxxxxxxxxx>
References: <1360667215-14701-1-git-send-email-lczerner@xxxxxxxxxx> <20130212202753.GC26694@dastard> <20130213080154.GC18597@xxxxxxxxxxx> <alpine.LFD.2.00.1302131127070.2315@(none)> <20130213121655.GA7799@xxxxxxxxxxx> <20130213221720.GH26694@dastard> <511CCE67.5010402@xxxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130107 Thunderbird/17.0.2
On 2/14/13 5:45 AM, Dave Howorth wrote:
> Dave Chinner wrote:
>> IOWs, it is the responsibility of the filesystem tools to correctly
>> identify the filesystem being operated on, and not to
>> modify/trash/recover anything unless specifically directed by the
>> user.  When a filesystem tool gets it wrong, then that specific tool
>> needs to be fixed.  i.e. it is the responsibility of filesystem
>> tools to behave sanely, not for the rest of the world to have to
>> work around the dangerous behaviour of a specific filesystems'
>> toolset.
> As an average Joe user, I started to agree with this, but then as a
> developer I had second thoughts. It can't be right that every filesystem
> tool has to have code to recognize every other type of filesystem; that
> just doesn't scale. So each tool would need to call some API, which I

Yep - it's called libblkid, it's very easy to use for this purpose.
xfsprogs already does, and I just sent a patch for btrfs-progs as well.

So libblkid contains all the smarts, really, and it's not a code duplication

> suppose would need to access some kernel code that iterated for every
> filesystem type the kernel was configured to handle, or knew historically.

Nah, it doesn't matter what the running kernel knows about, IMHO, just what
is recognized on the disk at hand.


> And then we have identical code in every tool, and that code is not
> serving the tool's primary purpose, so maybe it should be factored out
> on the one-tool-one-job philosophy. So perhaps there should be a single
> tool that tells what filesystem type is present on a device, which
> everybody runs before mkfs. Oh wait, df -T or other utilities already do
> that.
> So I'm not sure the issue is black and white. As an average Joe, I
> expect mkfs to trash whatever I give it, so I'm pretty careful to check
> what is there first. And if I expected to be overwriting an existing
> filesystem and I did it often enough to know about the mkfs.xfs
> behaviour, I suppose I would always invoke it with the -f flag.
> Consistency among the various flavours of mkfs would be nice, though.
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

<Prev in Thread] Current Thread [Next in Thread>