xfs
[Top] [All Lists]

Re: [PATCH] xfs_mkfs: wipe old signatures from the device

To: Chris Murphy <lists@xxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs_mkfs: wipe old signatures from the device
From: Lukáš Czerner <lczerner@xxxxxxxxxx>
Date: Thu, 14 Feb 2013 09:36:38 +0100 (CET)
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, Karel Zak <kzak@xxxxxxxxxx>, Lukáš Czerner <lczerner@xxxxxxxxxx>, xfs@xxxxxxxxxxx, sandeen@xxxxxxxxxx, Zach Brown <zabrown@xxxxxxxxxx>, linux-btrfs@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <982B8DBB-3FBA-4213-BC92-848A64C60110@xxxxxxxxxxxxxxxxx>
References: <1360667215-14701-1-git-send-email-lczerner@xxxxxxxxxx> <20130212202753.GC26694@dastard> <20130213080154.GC18597@xxxxxxxxxxx> <alpine.LFD.2.00.1302131127070.2315@(none)> <20130213121655.GA7799@xxxxxxxxxxx> <20130213221720.GH26694@dastard> <982B8DBB-3FBA-4213-BC92-848A64C60110@xxxxxxxxxxxxxxxxx>
User-agent: Alpine 2.00 (LFD 1167 2008-08-23)
On Thu, 14 Feb 2013, Chris Murphy wrote:

> Date: Thu, 14 Feb 2013 00:29:59 -0700
> From: Chris Murphy <lists@xxxxxxxxxxxxxxxxx>
> To: Dave Chinner <david@xxxxxxxxxxxxx>
> Cc: Karel Zak <kzak@xxxxxxxxxx>, Lukáš Czerner <lczerner@xxxxxxxxxx>,
>     xfs@xxxxxxxxxxx, sandeen@xxxxxxxxxx, Zach Brown <zabrown@xxxxxxxxxx>,
>     linux-btrfs@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] xfs_mkfs: wipe old signatures from the device
> 
> 
> On Feb 13, 2013, at 3:17 PM, Dave Chinner <david@xxxxxxxxxxxxx> wrote:
> > it is the responsibility of filesystem
> > tools to behave sanely, not for the rest of the world to have to
> > work around the dangerous behaviour of a specific filesystems'
> > toolset.
> 
> I appreciate this, and in particular that mkfs.xfs doesn't nerf a file system 
> without the use of -f; even an existing XFS file system. Considering most 
> data loss is user induced, I'd appreciate it if other file systems's tools 
> weren't so easily made belligerent by (hopefully temporarily) confused apes 
> wearing pants.
> 
> Chris Murphy

I would not be so optimistic about it. The reason being that there
are almost _always_ old file system signatures on the device. So I
think that it got to the point where users will usually use mkfs.xfs
-f all the time. And even if they did not and they would use a wrong
device they would probably get the same warning even for the device
they wanted to use in the first place.

So even thoug it might help in some cases I do not think that we
should go and change all file systems to do that as well, it would
not be very useful anyway.

-Lukas
<Prev in Thread] Current Thread [Next in Thread>