xfs
[Top] [All Lists]

Re: [PATCH 0/4] Refactor release scripts to conform to using git archive

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [PATCH 0/4] Refactor release scripts to conform to using git archive
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed, 13 Feb 2013 21:14:37 -0500 (EST)
Cc: Andrew Dahl <adahl@xxxxxxx>, xfs@xxxxxxxxxxx, Dave Chinner <david@xxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130214010853.GD22182@xxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Hi Ben,

----- Original Message -----
> On Wed, Feb 06, 2013 at 12:15:47PM +1100, Dave Chinner wrote:
> > ...
> > It breaks the 'make deb' command for all the trees.
> 
> xfsprogs: update 'make deb' to use tarball
> 
> This patch changes the build process so that 'make deb' uses the same
> process of creating a source tree as the release script.
> 
> * Add a list of files which go in the release tarball in .git_census
>   This is needed so that you can create a tarball in a bare release
>   tree, when .git is not available.
> 

I think you'll need .git_census in .gitignore (ala configure).
Possibly remove the underscore for naming consistency - *shrug*.

> 
> * 'make deb' now creates unsigned packages by default, 'make debsign'
>   creates signed packages.
> 

Ehrm - why?  Everything else in your patch worked, but this part broke
(which suggests a larger problem, in that this build path is no longer
checked on every build) ...

debsign: Can't find or can't read changes file !

> +debsign: deb
> +     debsign
> +

(That's not valid usage, FWIW).

I would recommend just removing that change in behaviour, "make deb"
was fine as it was (for me anyway, and evidently for Dave too).  Best
to go secure-by-default and not change this.

thanks!

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>